Skip to content

fix(symfony): do not load docs routes if docs disabled #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 4.2
Choose a base branch
from
Open

fix(symfony): do not load docs routes if docs disabled #7448

wants to merge 1 commit into from
+4 −1

Conversation

alexndlm
Copy link
Contributor

@alexndlm alexndlm commented Oct 8, 2025

Q A
Branch? 4.2
Tickets
License MIT
Doc PR

@alexndlm alexndlm changed the base branch from main to 4.2 October 8, 2025 12:25
soyuka
soyuka reviewed Oct 9, 2025
View reviewed changes
src/Symfony/Routing/ApiLoader.php
{
$routeCollection->addCollection($this->fileLoader->load('docs.xml'));
if ($this->docsEnabled) {
$routeCollection->addCollection($this->fileLoader->load('docs.xml'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GromNaN should we also move our routes to php?

@soyuka
Copy link
Member

soyuka commented Oct 9, 2025

We did not do this on purpose a when using JSON-LD you sematically need to have the docs.jsonld route. You should've a way to disable the openapi docs though no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka soyuka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexndlm @soyuka